-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix CI issues in 0.2 branch #4695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI issues in 0.2 branch #4695
Conversation
Fixes `useless_deprecated` error.
|
extern "C"
block to functions18456f6
to
08e4198
Compare
Okay, I think this fixes all FreeBSD-related CI issues. There's something massive going on with the style check, and the tier 1 tests are using an outdated Ubuntu non-LTS. I'm going to try to work around those. |
40ffb82
to
4b932bb
Compare
Tagging out for a while. Feel free to push further changes to this branch to fix CI for the remaining issues. |
Some of these FreeBSD issues already have PRs open for the main branch. Should we land them there first and then merge to libc-0.2 ? |
Fine by me. But we can't land anything on libc-0.2 with CI broken like this, so one way or another we need to get CI fully fixed. |
Mentioned on Zulip but this is expected: everything needs to target The two things that do need to be fixed are (1) Failures on the FreeBSD 15 CI, because that image only just started working again and it has the dev release churn; (2) the Linux docker image versions, since the Debian repo changes are recent (I'll take a look at that one). These should be fixed on |
…r `crate::` Hacks on top of hacks, to make the 0.2 branch deal with old tooling.
4b932bb
to
2c946fe
Compare
With the last batch of backports in #4710 CI is working on both branches, so I believe this has been obsoleted. |
Fix a wide variety of CI issues on the 0.2 branch that are preventing landing things.