Skip to content

Conversation

joshtriplett
Copy link
Member

@joshtriplett joshtriplett commented Sep 15, 2025

Fix a wide variety of CI issues on the 0.2 branch that are preventing landing things.

@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against libc-0.2. Please double check that you specified the right target!

@joshtriplett joshtriplett changed the title Move deprecated attribute from extern "C" block to functions Fix CI issues in 0.2 branch Sep 16, 2025
@rustbot rustbot added the O-x86 label Sep 16, 2025
@joshtriplett joshtriplett force-pushed the fix-deprecated-deprecated-usage branch 3 times, most recently from 18456f6 to 08e4198 Compare September 16, 2025 08:27
@joshtriplett
Copy link
Member Author

joshtriplett commented Sep 16, 2025

Okay, I think this fixes all FreeBSD-related CI issues. There's something massive going on with the style check, and the tier 1 tests are using an outdated Ubuntu non-LTS. I'm going to try to work around those.

@joshtriplett joshtriplett force-pushed the fix-deprecated-deprecated-usage branch 2 times, most recently from 40ffb82 to 4b932bb Compare September 16, 2025 09:22
@joshtriplett
Copy link
Member Author

Tagging out for a while. Feel free to push further changes to this branch to fix CI for the remaining issues.

@asomers
Copy link
Contributor

asomers commented Sep 16, 2025

Some of these FreeBSD issues already have PRs open for the main branch. Should we land them there first and then merge to libc-0.2 ?

@joshtriplett
Copy link
Member Author

Some of these FreeBSD issues already have PRs open for the main branch. Should we land them there first and then merge to libc-0.2 ?

Fine by me. But we can't land anything on libc-0.2 with CI broken like this, so one way or another we need to get CI fully fixed.

@tgross35
Copy link
Contributor

Fine by me. But we can't land anything on libc-0.2 with CI broken like this, so one way or another we need to get CI fully fixed.

Mentioned on Zulip but this is expected: everything needs to target main (#4688 is a backport). No need to try to fix the ancient ctest here, it won't be used anymore after the next batch of backports.

The two things that do need to be fixed are (1) Failures on the FreeBSD 15 CI, because that image only just started working again and it has the dev release churn; (2) the Linux docker image versions, since the Debian repo changes are recent (I'll take a look at that one). These should be fixed on main though, since the same problems exist there, so it's easiest if you change this PR's target branch and drop everything ctest-related.

@joshtriplett joshtriplett force-pushed the fix-deprecated-deprecated-usage branch from 4b932bb to 2c946fe Compare September 18, 2025 14:20
@tgross35
Copy link
Contributor

With the last batch of backports in #4710 CI is working on both branches, so I believe this has been obsoleted.

@tgross35 tgross35 closed this Sep 23, 2025
@joshtriplett joshtriplett deleted the fix-deprecated-deprecated-usage branch September 24, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants